-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xtrigger sequence fix #3285
Xtrigger sequence fix #3285
Conversation
1727f93
to
128c84c
Compare
ac23fc1
to
5bbdf57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally happy with these changes. A few comments on style.
c518a21
to
1c95277
Compare
1778f34
to
63bed59
Compare
(rebased) |
63bed59
to
18aa1ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ran it on my system, and the xtriggers were on sequence.
(just Travis now)
Thanks @dwsutherland 👍 |
Yay, the 7.8.x test battery passed, unbelievable 😮 (I stole a few fixes from @matthewrmshin's work on master). |
These changes partially address #3283 (companion PR to master will complete).
Major:
Minor:
wall_clock
works with positional or keywordoffset
arg (another problem identified by @trwhitcomb)Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.